Add Python3 compatibility#13
Open
goanpeca wants to merge 4 commits intoadswerve:masterfrom
goanpeca:py3
Open
Conversation
Author
|
@samba any chance of getting this merged? |
Contributor
|
@goanpeca Sorry for the late follow up. Thank you for this contribution, and remedying my lack of PEP-8 in the original authorship :) By visual inspection I believe the changes are sound, so I'll encourage Analytics Pros to merge these at their earliest opportunity. |
Author
|
@samba, 👍 |
Author
|
@LukaData now this has conflicts, should I fix or just close the PR? |
LukaData
approved these changes
Oct 15, 2016
|
@goanpeca can you provide commit to this PR with resolved conflict? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I needed to track some analytics and this library seemed to work fine except the python3 issue.
I added python3 compatibility using six, fixed the tests to run on py3 as well and fixed the code to be pep8 compliant.
I am using this in my fork now, but left this here in case the project is still supported.
Cheers